Merge async client #8
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an asynchronous client module to support non-blocking HTTP requests for the Sanity client and updates the Cargo.toml accordingly.
- Added a new async_client module with configuration and helper functions
- Introduced asynchronous implementations for fetching and processing JSON data
- Updated versioning and added the tokio dependency
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Added declaration for the new async_client module |
| src/async_client/mod.rs | Created module structure and re-exporting of config and helpers |
| src/async_client/helpers.rs | Added async helper to process JSON responses from reqwest |
| src/async_client/config.rs | Added configuration, URL building, and async query execution functions |
| Cargo.toml | Updated package version and added the tokio dependency |
|
|
||
| impl Query { | ||
| pub async fn execute(&self) -> Result<Value, Box<dyn std::error::Error>> { | ||
| let url = format!("{} {}", &self.base_url, &self.query.as_ref().unwrap()); |
There was a problem hiding this comment.
Concatenating the base URL and query with a space may lead to an improperly formatted URL. Consider using proper query parameter formatting (e.g., using '?' or '&' as appropriate) and ensuring the query is correctly appended.
| pub async fn get_json( | ||
| reqwest_res: reqwest::Response, | ||
| ) -> Result<Value, Box<dyn std::error::Error>> { | ||
| let data: Value = serde_json::from_str(&reqwest_res.text().await?)?; |
There was a problem hiding this comment.
[nitpick] Instead of converting the response text to JSON manually, it might be clearer and more efficient to use reqwest's built-in JSON deserialization with reqwest_res.json().await.
| let data: Value = serde_json::from_str(&reqwest_res.text().await?)?; | |
| let data: Value = reqwest_res.json().await?; |
2 participants
@gibsorya did some excellent work, merging in to upstream :)